Bartlomiej Zolnierkiewicz wrote: [...] > > > is incorrect as noted a month ago in: > > > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2013- > July/186355.html > > > > > > [ Because of the deficiency in the core cpuidle core (device- > >state_count > > > not being used by governors' code) only sysfs entries for C1 state > will be > > > disabled and EXYNOS cpuidle driver will still attempt to use C1 > state. > > > > > > also non-working device->state_count is planned to be removed by: > > > > > > http://permalink.gmane.org/gmane.linux.power-management.general/37390 > > I looked at your patch series and it seems reasonable. I will repost > > this patch on top of yours. > > If you correctly use driver's state_count (instead of device's) there will > be > no dependency on my patch series and the new patch can be applied > immediately. > > > But I suggest to keep this patch temporary till your patch series gets > merged. > > The current patch (the one Kukjin merged) is incorrect as it just doesn't > do what it advertises. I see no reason to keep it. > Well, I don't think so, because if the patch is missing, following kernel panic happens on exynos5440 platform. Unable to handle kernel paging request at virtual address f8180608 pgd = c0003000 [f8180608] *pgd=80000080007003, *pmd=af7fb003, *pte=00000000 Internal error: Oops: a07 [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 3.11.0-0-generic #1~d20130819t044008~3372c79 task: c0529d80 ti: c051e000 task.ti: c051e000 PC is at exynos4_enter_lowpower+0x18/0x130 LR is at cpuidle_enter_state+0x3c/0xe8 pc : [] lr : [] psr: 200f0093 sp : c051ff68 ip : 00000018 fp : 00000000 r10: 00000000 r9 : 412fc0f3 r8 : 00000000 r7 : c052c9cc r6 : 00000001 r5 : 00000000 r4 : d5c3cc94 r3 : f8180000 r2 : 0000ff3e r1 : c052c980 r0 : c052cc98 Flags: nzCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 30c5387d Table: af139b00 DAC: fffffffd Process swapper (pid: 0, stack limit = 0xc051e230) Stack: (0xc051ff68 to 0xc0520000) ff60: d5c3cc94 00000000 c052cc98 c02c1310 d5c3cc94 00000000 ff80: c0550288 c052c980 c058898c c052cc98 00000001 c052c980 c058898c c02c1458 ffa0: c051e000 c0550288 c0550288 00000001 c05260dc c001b2cc 000001fe c00573e4 ffc0: ffffffff c04f07d8 ffffffff ffffffff c04f0290 00000000 00000000 c05134d8 ffe0: 30c7387d c0526064 c05134d4 c052b5b4 80007000 80008080 00000000 00000000 [] (exynos4_enter_lowpower+0x18/0x130) from [] (cpuidle_enter_state+0x3c/0xe8) [] (cpuidle_enter_state+0x3c/0xe8) from [] (cpuidle_idle_call+0x9c/0x140) [] (cpuidle_idle_call+0x9c/0x140) from [] (arch_cpu_idle+0x8/0x38) [] (arch_cpu_idle+0x8/0x38) from [] (cpu_startup_entry+0x4c/0x114) [] (cpu_startup_entry+0x4c/0x114) from [] (start_kernel+0x324/0x37c) Code: 0a000043 e3a03000 e30f2f3e e34f3818 (e5832608) ---[ end trace 617b9e1a4ff91d2f ]--- Kernel panic - not syncing: Attempted to kill the idle task! In addition, I didn't see your patches in linux-next for upcoming merge window. So I think, if any fixup is required, it should be done on top of current shape. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |