On 08/21/2013 10:52 AM, Dan Carpenter wrote:
Hello Sylwester Nawrocki,
This is a semi-automatic email about new static checker warnings.
The patch 086eca2905d0: "[media] exynos4-is: Add Exynos5250 SoC
support to fimc-lite driver" from Jun 14, 2013, leads to the
following Smatch complaint:
drivers/media/platform/exynos4-is/fimc-lite.c:1521 fimc_lite_probe()
error: we previously assumed 'dev->of_node' could be null (see line 1511)
drivers/media/platform/exynos4-is/fimc-lite.c
1510
1511 if (dev->of_node) {
^^^^^^^^^^^^
Existing check.
1512 of_id = of_match_node(flite_of_match, dev->of_node);
1513 if (of_id)
1514 drv_data = (struct flite_drvdata *)of_id->data;
1515 fimc->index = of_alias_get_id(dev->of_node, "fimc-lite");
1516 }
1517
1518 if (!drv_data || fimc->index>= drv_data->num_instances ||
1519 fimc->index< 0) {
1520 dev_err(dev, "Wrong %s node alias\n",
1521 dev->of_node->full_name);
^^^^^^^^^^^^^^
Patch adds this dereference.
Thanks, this issue has been fixed in commit:
http://git.linuxtv.org/media_tree.git/commitdiff/6a40cbbe471bc7b821458973a5c18ba3d97d72f4
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
