Hi Tomasz, On 14 August 2013 17:00, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > Hi Vikas, > > On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote: >> changes since v2: >> - split the 5250 related modifications into a separate patch. > > I'm not sure whether Kukjin's comment was about this, as it introduces a > short bisect breakage between patch 1 and patch 2 from this series. > > IMHO it would be more sensible to make first patch simply fix name of the > node and then a separate patch adding the rtc node for exynos5420. > Are you saying that patch 1: should contain modifications for exynos5.dtsi and exynos5250.dtsi ( basically the RTC name change and status as "okay") patch 2: should contain modifications only for exynos5420.dtsi ( new RTC DT node ) > Best regards, > Tomasz > >> - placed the RTC node as per the alphabetical order in the DTS file as >> suggested by Kukjin Kim <kgene@xxxxxxxxxx>. >> >> changes since v1: >> - made DT node status as "okay" in the dtsi file itself. >> - >> Vikas Sajjan (2): >> ARM: dts: Add RTC DT node to Exynos5420 SoC >> ARM: dts: Fix the RTC DT node name for Exynos5250 SoC >> >> arch/arm/boot/dts/exynos5.dtsi | 2 +- >> arch/arm/boot/dts/exynos5250.dtsi | 3 ++- >> arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++ >> 3 files changed, 9 insertions(+), 2 deletions(-) -- Thanks and Regards Vikas Sajjan -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html