Hi Kukjin,
On Wed, Aug 14, 2013 at 11:14 AM, Kukjin Kim <kgene@xxxxxxxxxx> wrote:
> Vikas Sajjan wrote:
>>
>> Adds RTC DT node to Exynos5420 SoC.
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx>
>> ---
>> changes since v1:
>> - made DT node status as "okay" in the dtsi file itself.
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 2 +-
>> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
>> arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
>> 3 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi
>> b/arch/arm/boot/dts/exynos5.dtsi
>> index f65e124..4a8e223 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -95,7 +95,7 @@
>> interrupts = <0 54 0>;
>> };
>>
>> - rtc {
>> + rtc@101E0000 {
>> compatible = "samsung,s3c6410-rtc";
>> reg = <0x101E0000 0x100>;
>> interrupts = <0 43 0>, <0 44 0>;
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 88589b7..c82137b 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -178,9 +178,10 @@
>> samsung,power-domain = <&pd_mfc>;
>> };
>>
>> - rtc {
>> + rtc@101E0000 {
>> clocks = <&clock 337>;
>> clock-names = "rtc";
>> + status = "okay";
>
> Well, according to the subject, 'add rtc dt node to exynos5420', this should
> be handled separately if required.
>
So, you want me to spit this 5250 modification to a separate patch
OR
Modify the subject line to match the changes.
>> };
>>
>> tmu@10060000 {
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi
>> index 9e90d1e..8f1bb08 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -145,4 +145,11 @@
>> clocks = <&clock 260>, <&clock 131>;
>> clock-names = "uart", "clk_uart_baud0";
>> };
>> +
>> + rtc@101E0000 {
>
> Please put in the address order or alphabetical.
>
Sure will do.
>> + clocks = <&clock 317>;
>> + clock-names = "rtc";
>> + status = "okay";
>> + };
>> +
>
> No need last empty line.
OK.
>
> - Kukjin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
