On Tue, Aug 13, 2013 at 11:27:04AM +0900, Inki Dae wrote: > > Ensure that all externally accessed functions are correctly prototyped > > when defined in each file by making sure the headers with the protoypes > > are included in the file with the definition. > I definitely missed it. sorry about that. Actually I was going to try to > incur something such as compile warning. You mean that the warning could be > incurred by compiler in case that a external module includes a header of > Exynos drm but the prototype of the header file differs from the one of .c > file? Probably nothing would actively warn about a mismatch (since everything happens per complilation unit) without the file defining the function including the incorrect prototype but you'd get problems at runtime if the declaration and defintion were incompatible so some things (including sparse) will warn if there's no prototype for an exported symbol. > I will apply it to -next but I'd like to understand why this patch is needed > surely. And it seems like that other drivers have same issue also. :) Yes, it's a bit of a problem (especially in the graphics stack for some reason) but since there's tools that pick up the issue it does tend to get fixed.
Attachment:
signature.asc
Description: Digital signature
