Re: [PATCH] ARM: dts: Add RTC DT node to Exynos5420 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vikas,

On 12 August 2013 13:07, Vikas Sajjan <vikas.sajjan@xxxxxxxxxx> wrote:
> Adds RTC DT node to Exynos5420 SoC.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos5.dtsi    |    2 +-
>  arch/arm/boot/dts/exynos5250.dtsi |    2 +-
>  arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
>  3 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..4a8e223 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -95,7 +95,7 @@
>                 interrupts = <0 54 0>;
>         };
>
> -       rtc {
> +       rtc@101E0000 {
>                 compatible = "samsung,s3c6410-rtc";
>                 reg = <0x101E0000 0x100>;
>                 interrupts = <0 43 0>, <0 44 0>;
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 88589b7..f426ce6 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -178,7 +178,7 @@
>                 samsung,power-domain = <&pd_mfc>;
>         };
>
> -       rtc {
> +       rtc@101E0000 {
>                 clocks = <&clock 337>;
>                 clock-names = "rtc";
>         };

Since with this binding the h/w is depicted completely (for
functioning), IMO you should change the status to "okay" here.

> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 9e90d1e..b48d62c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -145,4 +145,10 @@
>                 clocks = <&clock 260>, <&clock 131>;
>                 clock-names = "uart", "clk_uart_baud0";
>         };
> +
> +       rtc@101E0000 {
> +               clocks = <&clock 317>;
> +               clock-names = "rtc";
> +       };
> +

ditto.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux