On Wednesday 07 of August 2013 14:40:12 Padmavathi Venna wrote: > This patch adds i2c bus 1 and wm8994 codec node on i2c bus1 and the > required regulator supplies and properties on smdk5420 board. > > Signed-off-by: Padmavathi Venna <padma.v@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 58 > +++++++++++++++++++++++++++++ 1 files changed, 58 insertions(+), 0 > deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts > b/arch/arm/boot/dts/exynos5420-smdk5420.dts index d05de7a..e86c1ae > 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -68,4 +68,62 @@ > bus-width = <4>; > }; > }; > + > + avdd2: fixed-regulator@0 { @ suffix should be present only if reg property is present as well. Otherwise a suffix separated with "-" should be used, like fixed- regulator-0. > + compatible = "regulator-fixed"; > + regulator-name = "avdd2-supply"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + cpvdd: fixed-regulator@1 { > + compatible = "regulator-fixed"; > + regulator-name = "cpvdd-supply"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + dbvdd: fixed-regulator@2 { > + compatible = "regulator-fixed"; > + regulator-name = "dbvdd-supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + spkvdd: fixed-regulator@3 { > + compatible = "regulator-fixed"; > + regulator-name = "spkvdd-supply"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; All these regulators should be made subnodes of a fixed-regulators node aggregating all fixed regulators on the board, like on following example: fixed-regulators { avdd2: fixed-regulator-0 { compatible = "regulator-fixed"; regulator-name = "avdd2-supply"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; cpvdd: fixed-regulator-1 { compatible = "regulator-fixed"; regulator-name = "cpvdd-supply"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; /* ... */ }; Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html