> > +static const struct of_device_id vfio_dt_match[] = { > > + � � /* In the future, we can implement a better mechanism to bind > the > > + � � �* module to any device. For now add the compatible property to > the > > + � � �* dtb of the devices we want to use. � */ > > + � � { > > + � � � � � � .compatible = "vfio-dt", > > + � � }, > > + � � {}, > > +}; > > This definitely doesn't belong in the dt. It's purely a Linux > abstraction and does not represent a piece of hardware or common > interface. > > We need to think of a better mechanism for binding the module to these > devices now. > > I already make this remark in the cover letter; thanks for confirming it. > � > Antonios Sorry, I found the cover letter a little unclear in that regard. Thanks for the clarification :) Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html