On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote: > +static int phy_get_id(void) > +{ > + int ret; > + int id; > + > + ret = ida_pre_get(&phy_ida, GFP_KERNEL); > + if (!ret) > + return -ENOMEM; > + > + ret = ida_get_new(&phy_ida, &id); > + if (ret < 0) > + return ret; > + > + return id; > +} ida_simple_get() instead? And if you do that, you can get rid of this function entirely. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html