Hi Vikas, Yadwinder, Please see my comments inline. On Monday 29 of July 2013 19:19:27 Vikas Sajjan wrote: > From: Yadwinder Singh Brar <yadi.brar@xxxxxxxxxxx> > > Add DT nodes for gsc, isp, mfc, disp, mau, g2d and msc PM domains. > > Signed-off-by: Yadwinder Singh Brar <yadi.brar@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5420.dtsi | 35 > +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index 8c54c4b..bd6b310 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -90,6 +90,41 @@ > }; > }; > > + gsc_pd: pd@10044000 { Please use power-domain for node names. We might have "pd" for other Exynos SoCs, but this needs to be fixed. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html