> -----Original Message----- > From: Antonios Motakis [mailto:a.motakis@xxxxxxxxxxxxxxxxxxxxxx] > Sent: Friday, July 26, 2013 12:35 AM > > On success, the __sysmmu_enable returns 1 instead of 0, which does not > respect the convention described in Chapter 16 of the Linux kernel coding > style. > > In fact, this return value is propagated all the way up to > iommu_attach_device() and iommu_attach_device() in drivers/iommu.c, > which results into inconsistent behavior of the IOMMU API with Exynos > systems, compared to other IOMMUs. > > This patch replaces the return value with 0, which makes the Exynos' > IOMMU driver behavior consistent with that of other IOMMUs. > > Signed-off-by: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/iommu/exynos-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c7dd4b5..4ea3abb 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -504,7 +504,7 @@ static int __sysmmu_enable(struct sysmmu_drvdata *data, > > dev_dbg(data->sysmmu, "Enabled\n"); > } else { > - ret = (pgtable == data->pgtable) ? 1 : -EBUSY; > + ret = (pgtable == data->pgtable) ? 0 : -EBUSY; > Ok. __sysmmu_enable() must return 1 if it is called with the same page table. I have fixed it exynos_iommu_attach_device() to always return zero on success in the next patchset which I will post today. Thank you. > dev_dbg(data->sysmmu, "already enabled\n"); > } > -- > 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |