Hi Sachin,
On Wed, Jul 24, 2013 at 3:31 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Hi Tomasz,
>
> On 24 July 2013 15:24, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote:
>> Hi Sachin,
>>
>> On Wednesday 24 of July 2013 15:18:26 Sachin Kamat wrote:
>>> Hi Leela,
>>>
>>> On 24 July 2013 15:08, Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
>> wrote:
>>> > This patch adds clock entries to watchdog node for exynos5420
>>> > as per the common clock framework of exynos5420
>>> >
>>> > Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>>> > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>>> > Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
>>> > ---
>>> >
>>> > arch/arm/boot/dts/exynos5420.dtsi | 6 ++++++
>>> > 1 file changed, 6 insertions(+)
>>> >
>>> > diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>>> > b/arch/arm/boot/dts/exynos5420.dtsi index 8c54c4b..e1d2d20 100644
>>> > --- a/arch/arm/boot/dts/exynos5420.dtsi
>>> > +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>> > @@ -145,4 +145,10 @@
>>> >
>>> > clocks = <&clock 260>, <&clock 131>;
>>> > clock-names = "uart", "clk_uart_baud0";
>>> >
>>> > };
>>> >
>>> > +
>>> > + watchdog {
>>> > + clocks = <&clock 316>;
>>> > + clock-names = "watchdog";
>>> > + status = "okay";
>>>
>>> Generally you do "okay" in specific board dts files.
>>
>> Not necessarily. The status property should be set to okay whenever the
>> device represented by such node can already work with given set of
>> information (properties).
>>
>> Given the fact that watchdog driver does not require any board specific
>> information, it can be instantiated regardless of the board.
>
> Yes you are right. But I was thinking of keeping this (enabling) as an
> option at the board level.
> We do this for some of the other IPs too where even though we have all
> the properties we keep them disabled.
>
Watchdog does not require any board specific information so I kept it
in 5420.dtsi file.
Best wishes,
Leela Krishna.
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
