Hi Mark, On Fri, Jul 12, 2013 at 2:19 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, Jul 12, 2013 at 10:07:22AM +0530, Padma Venkat wrote: > >> A new version number is added when a there was some change in the IP >> like adding a internal mux to the IP, adding multi channel support, >> adding reset control bit. This was done in the older code with >> platform device. >> Same thing is followed here. So as previously done, adding a new >> compatible name like "samsung,i2s-v6" with new quirk >> "samsung,supports-tdm" is okey? > > Yes, this is good but the quirk should just be found by software based > on the compatible string rather than in the DT. You mean I just need to initialize the quirks in the driver based on the compatible string? So what about the quirks that I added previously on 5250? Should I also follow the same thing for other quirks? Or it need to be passed via driver data as it is done in spi driver? Please clarify me. Thanks Padma -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html