On Monday 22 of July 2013 21:15:12 Fabio Estevam wrote: > On Mon, Jul 22, 2013 at 8:49 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > > dev_dbg(&dev->dev, "s3c2410_start_hc:\n"); > > > > - clk_enable(usb_clk); > > + clk_prepare_enable(usb_clk); > > clk_prepare_enable may fail, so you would better check its return > value. Well, ideally yes, but since this driver doesn't have any error path here anyway and on Samsung platforms clk_prepare_enable() simply can't fail, I'd keep it this way until somebody fixes this driver, as it has more issues than just this one. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |