Re: [PATCH v2] spi: s3c64xx: fix casting warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 17 of July 2013 11:08:16 Mark Brown wrote:
> On Wed, Jul 17, 2013 at 05:54:11PM +0900, Jingoo Han wrote:
> > sdd->ops->request is unsigned int, not unsigned long.
> > Also, sdd->rx_dma.ch is a 'struct dma_chan *'.
> > Thus, (void *) is converted to (struct dma_chan *)(unsigned long),
> > in order to fix possible sparse warnings.
> 
> Applied, though only the cast to unsigned long should actually be needed
> - casting to void * should be good for any pointer so changing to the
> specific struct shouldn't be essential (might catch issues due to
> future API changes though).

Well, hopefully the old S3C DMA API with all its brokenness will get 
removed soon and we switch to generic DMA engine API. (I already have 
patches to migrate Samsung ASoC and SPI is being worked on.)

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux