On 07/20/2013 07:42 AM, NAVEEN KRISHNA CHATRADHI wrote: > Hello Sebastian, Hello Naveen, > > I just did one more testing. > > In case of iio/adc/exynos_adc.c there is a bug in the remove path. > If I fix the bug in the driver, with below patch > > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/adc/exynos_adc.c > @@ -375,14 +375,14 @@ static int exynos_adc_remove(struct platform_device *pdev) > struct iio_dev *indio_dev = platform_get_drvdata(pdev); > struct exynos_adc *info = iio_priv(indio_dev); > > - device_for_each_child(&pdev->dev, NULL, > - exynos_adc_remove_devices); > regulator_disable(info->vdd); > clk_disable_unprepare(info->clk); > writel(0, info->enable_reg); > iio_device_unregister(indio_dev); > free_irq(info->irq, info); > iio_device_free(indio_dev); > + device_for_each_child(&pdev->dev, NULL, > + exynos_adc_remove_devices); > > Even without your fix, I could configure it as a module and the rmmod, insmod are working fine. (no crash) I have no idea why you moved it. I haven't found any .dts with this binding but from the binding document I would assume that you do not have any memory resources and therefore you don't see that crash. > Regards, > Naveen Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |