On Friday, July 19, 2013 5:58 PM, Leela Krishna Amudala wrote:
>
> This patch removes the global variables in the driver file and
> group them into a structure.
How about changing the subject as below?
[PATCH] watchdog: s3c2410_wdt: remove the global variables
[.....]
> -static struct device *wdt_dev; /* platform device attached to */
> -static struct resource *wdt_mem;
> -static struct resource *wdt_irq;
> -static struct clk *wdt_clock;
> -static void __iomem *wdt_base;
> -static unsigned int wdt_count;
> -static DEFINE_SPINLOCK(wdt_lock);
> +struct s3c2410_watchdog {
> +struct device *dev; /* platform device attached to */
> +struct clk *clock;
> +void __iomem *reg_base;
> +unsigned int count;
> +spinlock_t lock;
> +struct watchdog_device wdt_device;
> +struct notifier_block freq_transition;
> +};
'tab' is necessary as below:
+struct s3c2410_watchdog {
+ struct device *dev; /* platform device attached to */
+ struct clk *clock;
+ void __iomem *reg_base;
+ unsigned int count;
+ spinlock_t lock;
+ struct watchdog_device wdt_device;
+ struct notifier_block freq_transition;
+};
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
