> From: grundler@xxxxxxxxxx [mailto:grundler@xxxxxxxxxx] On Behalf Of Grant Grundler > Sent: Tuesday, July 16, 2013 1:19 AM > > On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo <pullip.cho@xxxxxxxxxxx> wrote: > ... > >> Maybe you could add LV1TABLE_SIZE define and use it here (there is > >> already a LV2TABLE_SIZE define)? > > > > Yes. But, LV2TABLE_SIZE is used in more places than one. > > I do not feel that it is needed to define LV1TABLE_SIZE for the single line. > > Cho, > #define's are part of the code "documentation". Doesn't really matter > how often it's used. I think Bartlomiej's suggestion is a good one. > > Key is to use "consistent" names so they makes sense to someone not > familiar with the code. In this case, we want to show this use is the > same way LV2TABLE_SIZE is used and serves the same purpose. > Ok. I agree the error handling code is not pretty to understand. I will change it in the next patch. > cheers. > grant Thank you. Cho KyongHo. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |