On Thu, Jul 11, 2013 at 12:38:24PM +0530, Padmavathi Venna wrote: > -#define MOD_LR_LLOW (0 << 7) > -#define MOD_LR_RLOW (1 << 7) > -#define MOD_SDF_IIS (0 << 5) > -#define MOD_SDF_MSB (1 << 5) > -#define MOD_SDF_LSB (2 << 5) > -#define MOD_SDF_MASK (3 << 5) > +#define MOD_LR_LLOW 0 > +#define MOD_LR_RLOW 1 > +#define MOD_SDF_SHIFT 5 > +#define MOD_SDF_IIS 0 > +#define MOD_SDF_MSB 1 > +#define MOD_SDF_LSB 2 > +#define MOD_SDF_MASK 3 This patch has an awful lot of coding style changes like this which are just coding style changes and not implementing TDM support. These should be done separately, not as part of the same patch, in order to make the code easier to review. > case 768: > - mod |= MOD_RCLK_768FS; > + mod |= (MOD_RCLK_768FS << rfs_shift); > break; This stuff is another example. I think the change itself should be fine but I'm not 100% sure I'm correctly identifying what's a stylistic change and what's a functional change.
Attachment:
signature.asc
Description: Digital signature
