Re: [PATCH 2/3] of/documentation: Update G2D documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomasz,

On 6 July 2013 05:22, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
> Hi Sachin,
>
> On Friday 05 of July 2013 14:12:28 Sachin Kamat wrote:
>> Exynos5250 G2D IP requires only the gate clock. Update the
>> binding documentation accordingly.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> Cc: Inki Dae <inki.dae@xxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/gpu/samsung-g2d.txt        |    4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt index
>> 3f454ff..60ca631 100644
>> --- a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -12,7 +12,9 @@ Required properties:
>>    - interrupts : G2D interrupt number to the CPU.
>>    - clocks : from common clock binding: handle to G2D clocks.
>>    - clock-names : from common clock binding: must contain "sclk_fimg2d"
>> and -           "fimg2d", corresponding to entries in the clocks
> property. +
>>  "fimg2d" for S5PV210 & Exynos4 based SoCs and "fimg2d" for +
>> Exynos5250 SoC, corresponding to entries in the clocks
>> +               property.
>
> I think this needs to be rephrased, because I can't get any sense from
> this sentence.
>
> Maybe something like:
>
> - clock-names : names of clocks listed in clocks property, in the same
> order, depending on SoC type:
>     - for S5PV210 and Exynos4 based SoCs : "fimg2d" and "sclk_fimg2d"
>     - for Exynos5250 SoC : "fimg2d".
>
> What do you think?

Sure. Will update and re-send.

Thanks for the review.


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux