On Tuesday 25 of June 2013 00:22:42 Kukjin Kim wrote:
> On 06/22/13 22:06, Tomasz Figa wrote:
> > This patch introduces new Samsung PWM driver, which is heavily
> > cleaned,
> > multiplatform aware and supports DeviceTree based instantiation.
> >
> > Since on historical hardware PWM block can be shared with clocksource
> > driver, a shared spinlock is used to protect access to shared
> > registers, already exported from the clocksource driver.
> >
> > Signed-off-by: Tomasz Figa<tomasz.figa@xxxxxxxxx>
> > ---
> >
> > drivers/pwm/Makefile | 1 +
> > drivers/pwm/pwm-samsung.c | 601
> > ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 602
> > insertions(+)
> > create mode 100644 drivers/pwm/pwm-samsung.c
> >
> > Changes since v2:
> > - Replaced __raw_{readl,writel} with {readl,writel}.
> > - Corrected commit message.
>
> [...]
>
> > + of_property_for_each_u32(np, "samsung,pwm-outputs", prop, cur,
val)
> > {
> > + if (val>= SAMSUNG_PWM_NUM) {
> > + pr_warning("%s: invalid channel index in
samsung,pwm-outputs
> > property\n",
> Just note, checkpatch complains following, so fixed to use pr_warn()
> when I applied.
>
> WARNING: Prefer pr_warn(... to pr_warning(...
> #471: FILE: drivers/pwm/pwm-samsung.c:432:
> + pr_warning("%s: invalid channel index in
samsung,pwm-outputs
> property\n",
>
> [...]
>
> > +
> > +static struct dev_pm_ops pwm_samsung_pm_ops = {
>
> WARNING: struct dev_pm_ops should normally be const
> #622: FILE: drivers/pwm/pwm-samsung.c:583:
> +static struct dev_pm_ops pwm_samsung_pm_ops = {
>
> fixed to add const when I applied.
Oops, I forgot to fix them, sorry. Thank you for fixing and applying.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
