On Friday 21 of June 2013 16:04:38 Arnd Bergmann wrote: > On Friday 21 June 2013, Tomasz Figa wrote: > > Since we now have a proper Samsung PWM clocksource driver in place, > > we can proceed with further cleanup of PWM timers support on Samsung > > SoCs.> > > This series attempts to achieve this goal by: > > 1) moving remaining Samsung platforms to the new clocksource driver > > 2) removing old clocksource driver > > 3) adding new multiplatform- and DT-aware PWM driver > > 4) moving all Samsung platforms to use the new PWM driver > > 5) removing old PWM driver > > 6) removing all PWM-related code that is not used anymore > > > > Cleaning up the PWM driver is a bit tricky, because the design of > > current driver makes it completely unsuitable for DT and > > multiplatform and would require a heavy rework to make it usable, > > breaking any existing Samsung PWM users by the way. To avoid any > > breakage I decided to keep the old driver, add new one, move all > > platforms to it and then remove the old one. > > > > See particular patches for more detailed descriptions. > > > > On S3C6410-based Tiny6410 (Mini6410-compatible), after enabling > > pwm-beeper and Exynos4210-based Origen board (with PWM0 attached to a > > scope): > > > > Tested-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> > > Looks good to me, > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Thanks. > Two small comments: > > * always use 'git format-patch -M' to detect renames (patch 10) > > * for new code, don't use __raw_readl and similar functions but > use readl_relaxed or plain readl. Just posted v3 of patches 10 and 11 addressing these issues. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |