On 19-06-2013 18:54, Eduardo Valentin wrote: > On 17-06-2013 02:46, Amit Daniel Kachhap wrote: >> This patch removes the error return in the bind/unbind routine >> as the platform may not register any cpufreq cooling data. >> >> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> >> Acked-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx> >> Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> >> --- >> drivers/thermal/samsung/exynos_thermal_common.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c >> index 7064eb7..86d39aa 100644 >> --- a/drivers/thermal/samsung/exynos_thermal_common.c >> +++ b/drivers/thermal/samsung/exynos_thermal_common.c >> @@ -131,7 +131,7 @@ static int exynos_bind(struct thermal_zone_device *thermal, >> tab_size = data->cooling_data.freq_clip_count; >> >> if (tab_ptr == NULL || tab_size == 0) >> - return -EINVAL; >> + return 0; >> >> /* find the cooling device registered*/ >> for (i = 0; i < th_zone->cool_dev_size; i++) >> @@ -180,7 +180,7 @@ static int exynos_unbind(struct thermal_zone_device *thermal, >> tab_size = data->cooling_data.freq_clip_count; >> >> if (tab_size == 0) >> - return -EINVAL; >> + return 0; >> >> /* find the cooling device registered*/ >> for (i = 0; i < th_zone->cool_dev_size; i++) >> > > I have one question before acking this one: what happens if one > registers a TMU with no freq tab? Say the case where you have three > sensors, just like SOC_ARCH_EXYNOS5440. Would you register > cpufreq_cooling device for all of them? In other way, are you having 3 > cpufreq_cooling devices? I am actually fine with this patch. just saw that you adjust things on patch 16. Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxx> > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Attachment:
signature.asc
Description: OpenPGP digital signature
