On Tuesday 18 June 2013, Eduardo Valentin wrote: > The driver will work on supported exynos variants. Those that have the > need for thermal sensing. And each of them have specific thermal needs > (trigger points, thresholds, etc). That is what this file tries to > isolate. And there is specific data structures for each soc version. Correct. My point is that the driver itself is much larger than the SoC-specific data sets in it. There is no reason to conditionally build a 108 byte data structure, making it more maintainably by removing all the #ifdef far outweighs the cost. You can also change the driver to work only for DT based booting, that will simplify it further and save you more in terms of object code size than the exynos_tmu_platform_data instances. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |