On Mon, Jun 17, 2013 at 1:57 PM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > On Monday 17 of June 2013 15:08:12 Sachin Kamat wrote: >> 'exynos_wkup_irq_ack' should be defined ahead of its call. >> >> Fixes the following error: >> drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’: >> drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of >> function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration] >> exynos_wkup_irq_ack(irqd); >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> Cc: Doug Anderson <dianders@xxxxxxxxxxxx> >> --- >> Fixed the commit message. >> --- > > This patch is incorrect. > > Compilation error is caused by merge error of Doug's patch: > > pinctrl: exynos: ack level-triggered interrupts before unmasking > > hunk of which went to wrong function - mask instead of unmask. OK probably I just had git am fail on me and used patch -p1 < ... > Linus, could you fix it? No I'm afraid I will cause more trouble. I took out Doug's commit and this fi from my tree. Doug, can you respin the patch "pinctrl: exynos: ack level-triggered interrupts before unmasking" On top of my "devel" branch? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html