On Tuesday 18 of June 2013 00:43:41 Kukjin Kim wrote: > On 06/17/13 22:19, Tomasz Figa wrote: > > Hi Heiko, > > > > On Friday 14 of June 2013 00:45:27 Heiko Stübner wrote: > >> When a pinctrl driver is loaded legacy gpio support has to be disabled. > >> The code checking for the pinctrl presence is contained in an #ifdef > >> checking for the presence of a valid samsung pinctrl driver. > >> > >> There the new PINCTRL_S3C24XX was missing resulting in the check never > >> being run and the gpio being enabled breaking the pinctrl driver. > >> > >> Fix this by adding the missing CONFIG_PINCTRL_S3C24XX > >> > >> Signed-off-by: Heiko Stuebner<heiko@xxxxxxxxx> > >> --- > >> > >> drivers/gpio/gpio-samsung.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c > >> index a1392f4..c84503e 100644 > >> --- a/drivers/gpio/gpio-samsung.c > >> +++ b/drivers/gpio/gpio-samsung.c > >> @@ -2949,7 +2949,8 @@ static __init int samsung_gpiolib_init(void) > >> > >> int i, nr_chips; > >> int group = 0; > >> > >> -#if defined(CONFIG_PINCTRL_EXYNOS) || defined(CONFIG_PINCTRL_EXYNOS5440) > >> +#if defined(CONFIG_PINCTRL_EXYNOS) || defined(CONFIG_PINCTRL_EXYNOS5440) > >> || \ + defined(CONFIG_PINCTRL_S3C24XX) > > > > I wonder if this wouldn't be simply covered by PINCTRL_SAMSUNG (except > > PINCTRL_EXYNOS5440 which doesn't use the common part). > > Well, not added compatible for 's3c64xx-pinctrl' yet? Right, but this shouldn't have any effect on this code. PINCTRL_S3C64XX isn't selected by anything yet, so PINCTRL_SAMSUNG won't be selected when ARCH_S3C64XX is used. As for s3c64xx DT support, I'm planning to finally post patches this week. Best regards, Tomasz > - Kukjin > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |