On Thursday 13 of June 2013 09:34:43 Doug Anderson wrote: > Tomasz, > > On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > > Hi Doug, > > > > On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: > >> A level-triggered interrupt should be acked after the interrupt line > >> becomes inactive and before it is unmasked, or else another interrupt > >> will be immediately triggered. Acking before or after calling the > >> handler is not enough. > > > > Nice catch. > > > > I guess that pinctrl-s3c64xx will need similar fix as well, won't it? > > It needs this whole series of 3, probably. The mask and unmask need > the lock and as well as the acking for level interrupts. > > I don't have any way to test that code but it's a pretty simple change > to make. Do you want to do it or do you have an idea of someone who > should? I'll take care of s3c64xx, probably as a part of my patches finally adding DT support for it, as without them the pinctrl-s3c64xx driver is just sitting there unused. > > I think you can eliminate most of the code by doing this following way: > > if (irqd_get_trigger_type(irqd) & IRQ_TYPE_LEVEL_MASK) > > > > exynos_gpio_irq_ack(irqd); > > Duh, right. OK, v2 coming shortly. Good! > Thank you for pointing out the > right way to do this! :) You're welcome. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |