On 11 June 2013 09:46, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> On 5 June 2013 17:44, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
>> Sachin Kamat wrote:
>>>
>>> These symbols are used only in this file and hence should be
>>> static.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>>> ---
>>> drivers/clk/samsung/clk-exynos4.c | 26 ++++++++++++++------------
>>> 1 file changed, 14 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-
>>> exynos4.c
>>> index 7104669..26f2a85 100644
>>> --- a/drivers/clk/samsung/clk-exynos4.c
>>> +++ b/drivers/clk/samsung/clk-exynos4.c
>>> @@ -339,24 +339,26 @@ PNAME(mout_user_aclk200_p4x12) = {"fin_pll",
>>> "div_aclk200", };
>>> PNAME(mout_user_aclk266_gps_p4x12) = {"fin_pll", "div_aclk266_gps", };
>>>
>>> /* fixed rate clocks generated outside the soc */
>>> -struct samsung_fixed_rate_clock exynos4_fixed_rate_ext_clks[] __initdata
>>> = {
>>> +static struct
>>> +samsung_fixed_rate_clock exynos4_fixed_rate_ext_clks[] __initdata = {
>>
>> Any reason to use double lines?
>
> This is one of the ways to avoid exceeding 80 column limit.
>
>>
>>> FRATE(xxti, "xxti", NULL, CLK_IS_ROOT, 0),
>>> FRATE(xusbxti, "xusbxti", NULL, CLK_IS_ROOT, 0),
>>> };
>>
>> [...]
>>
>>> -struct samsung_fixed_rate_clock exynos4210_fixed_rate_clks[] __initdata =
>>> {
>>> +static struct
>>> +samsung_fixed_rate_clock exynos4210_fixed_rate_clks[] __initdata = {
>>
>> Same as above.
>>
>>> FRATE(none, "sclk_usbphy1", NULL, CLK_IS_ROOT, 48000000),
>>> };
>>>
>> [...]
>>
>> Others look good to me,
>> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
>>
>> Mike, please pick this into the clk tree if you're ok.
>>
>
> Mike,
> If you are taking this through your tree, please also take the below
> patch [1] as it is dependent on this series.
> [1] https://patchwork.kernel.org/patch/2469891/
Ping Mike..
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
