Doug, >> Hmm, if done properly, it could simplify PLL registration in SoC clock >> initialization code a lot. >> >> I'm not sure if this is really the best solution (feel free to suggest >> anything better), but we could put PLLs in an array, like other clocks, >> e.g. >> >> ... exynos4210_pll_clks[] = { >> CLK_PLL45XX(...), >> CLK_PLL45XX(...), >> CLK_PLL46XX(...), >> CLK_PLL46XX(...), >> }; >> >> and then just call a helper like >> >> samsung_clk_register_pll(exynos4210_pll_clks, >> ARRAY_SIZE(exynos4210_pll_clks)); > > Something like that looks like what I was thinking. I'd have to see > it actually coded up to see if there's something I'm missing that > would prevent us from doing that, but I don't see anything. The only issue I see with this is that we may only want to register a rate table with a PLL only if fin_pll is running at a certain rate. On 5250 and 5420, for example, we have EPLL and VPLL rate tables that should only be registered if fin_pll is 24Mhz. We may have to register those separately, but this approach seems fine otherwise. -Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html