Re: [PATCH 1/3] ARM: dts: add pinctrl support to Exynos5420

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 12 of June 2013 14:35:30 Doug Anderson wrote:
> Tomasz,
> 
> On Wed, Jun 12, 2013 at 2:20 PM, Doug Anderson <dianders@xxxxxxxxxxxx> 
wrote:
> > Tomasz,
> > 
> > On Wed, Jun 12, 2013 at 1:58 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> 
wrote:
> >>> +     pinctrl@13400000 {
> >>> +             gpy7: gpy7 {
> >>> +                     gpio-controller;
> >>> +                     #gpio-cells = <2>;
> >>> +
> >>> +                     interrupt-controller;
> >>> +                     #interrupt-cells = <2>;
> >> 
> >> According to patch 2/3, this bank doesn't support interrupts, as it's
> >> defined using EINTN macro. Which variant is correct?
> > 
> > As far as I know the GPY registers don't support interrupts, so this
> > should be removed.  Nice catch!
> 
> Argh.  I'm not sure what I was just searching before (I probably
> messed up and searched for gpy6 or something), but I just searched
> again and am now seeing that GPY7 actually does support interrupts,
> unlike all of the other gpy banks.

This or other way, one of the patches needs to be fixed. If this bank 
supports interrupts, the patch adding driver data needs to be adjusted to 
use the EINTG macro.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux