On 06/11/2013 12:00 AM, Tomasz Figa wrote:
> On Monday 10 of June 2013 09:40:43 Tushar Behera wrote:
>> On 06/08/2013 04:16 PM, Tomasz Figa wrote:
>>> Hi Tushar, Sachin,
>>>
>>> On Friday 07 of June 2013 16:37:13 Tushar Behera wrote:
>>>> From: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>>>>
>>>> Adds pinctrl entries required by FIMD.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>>>> Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
>>>> ---
>>>>
>>>> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 75
>>>>
>>>> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726
>>>> 100644
>>>> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
>>>> @@ -330,6 +330,81 @@
>>>>
>>>> samsung,pin-pud = <3>;
>>>> samsung,pin-drv = <0>;
>>>>
>>>> };
>>>>
>>>> +
>>>> + pwm0_out: pwm0-out {
>>>> + samsung,pins = "gpd0-0";
>>>> + samsung,pin-function = <2>;
>>>> + samsung,pin-pud = <0>;
>>>> + samsung,pin-drv = <0>;
>>>> + };
>>>> +
>>>> + pwm1_out: pwm1-out {
>>>> + samsung,pins = "gpd0-1";
>>>> + samsung,pin-function = <2>;
>>>> + samsung,pin-pud = <0>;
>>>> + samsung,pin-drv = <0>;
>>>> + };
>>>
>>> Hmm, these two seem to be unrelated. Rebase error? :)
>>
>> Not a rebase error. pwm0_out needs to configured to get display on LCD.
>
> Please split this into two separate patches than, one adding LCD pin
> configuration nodes and one adding PWM pin configuration nodes.
>
> Also I think it would be better to just define all available PWM outputs
> not only first two. if you are already at adding PWM pin configurations.
>
Sure.
> Thanks,
> Tomasz
>
Thanks.
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
