Vikas and Yadwinder, On Fri, May 31, 2013 at 5:31 AM, Vikas Sajjan <vikas.sajjan@xxxxxxxxxx> wrote: > struct clk * __init samsung_clk_register_pll36xx(const char *name, > @@ -264,6 +318,11 @@ struct clk * __init samsung_clk_register_pll36xx(const char *name, > init.parent_names = &pname; > init.num_parents = 1; > > + if (rate_table && rate_count) > + init.ops = &samsung_pll36xx_clk_ops; > + else > + init.ops = &samsung_pll36xx_clk_min_ops; > + > pll->hw.init = &init; > pll->base = base; > pll->rate_table = rate_table; Interesting. In the gerrit review you sent for v2 you properly removed the line: init.ops = &samsung_pll36xx_clk_ops; ...but the v2 you posted upstream didn't have that removal. You've also lost it in v3. Perhaps you can add that back in? I'll do it locally before applying. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html