On 14-05-2013 05:58, Amit Daniel Kachhap wrote: > This patch removes the dependency on CPU_THERMAL for compiling TMU driver. > This is useful for cases when only TMU controller needs to be initialised > without cpu cooling action. Agreed with your intention. I just do not know if it makes sense to make this change at this point. Maybe after you have split the code? The above concern is simply from a non-functional perspective. If you do this at this point of your series, your driver may have compilation issues at this specific commit, in case your config does not have CONFIG_CPU_THERMAL. I recommend you moving this patch further in your series, to a place where you have isolated the code that depends on CPU_THERMAL. > > Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> > --- > drivers/thermal/samsung/Kconfig | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig > index 145a55d..b5ab971 100644 > --- a/drivers/thermal/samsung/Kconfig > +++ b/drivers/thermal/samsung/Kconfig > @@ -4,7 +4,6 @@ config ARCH_HAS_TMU > config EXYNOS_THERMAL > tristate "Temperature sensor on Samsung EXYNOS" > depends on ARCH_HAS_TMU > - depends on CPU_THERMAL > help > If you say yes here you get support for TMU (Thermal Management > Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Attachment:
signature.asc
Description: OpenPGP digital signature
