Tomasz, On Tue, May 21, 2013 at 10:05 AM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > return 0; > + > +err_domains: > + bank = d->ctrl->pin_banks; > + for (undo = 0; undo < i; ++undo) { ++bank is missing, I think. This will free the same bank many times. optional: could also avoid extra 'undo' variable and remove in reverse order by changing i to signed and counting down to 0. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html