On Friday 17 of May 2013 13:56:39 Doug Anderson wrote: > Tomasz, > > On Fri, May 17, 2013 at 1:23 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > >> I'd rather see you modify patch set #2 to provide some function to > >> retrieve just the eint mask and then use it here. Your patch removes > >> this test and doesn't replace it with anything. If you moved this > >> test to pinctrl directly you'd lose the test against intallow. > > > > Well, looking from the perspective of status before my patch, it just > > bypasses a test that is incorrect on DT-enabled platforms. > > True. What was there before was broken and this avoids the broken code. > > I agree that this test is rather reasonable to have, but it would > > require defining a new interface and moving all platforms to it, > > which for now would be a bit of overkill. > > It seems like you could use the same type of solution as patch set #2? > > ...oh, but that's only for exynos! I guess we would need something > similar for other platforms. ...and until we do those other platforms > (including S3C64xx, I think) are still using the old > s3c_irqwake_eintmask, right? Correct. Also as an extra side note, intallow is used here as a mask of valid eintmask bits on given platform. On Exynos SoCs there are 32 EINTs, so this extra mask is not needed. > ...so overall your patch series only fully fixes exynos, though it > does make other platforms less broken which is a plus. :) > > > IMHO a separate series that sanitizes the whole PM handling in plat- > > samsung, including a rework of this check to make it cover all > > platforms in a generic and multiplatform-friendly way. What do you > > think? > Sure, I think that would be OK. > > >> Ah, the important part here is the "saved", not the "save"! The > >> "save" should get a NULL chip for all GPIOs and effectively be a > >> no-op. > >> > >> Skipping the "saved" is important of s3c64xx and s5p64x0 where the > >> "saved" seems to transition things over to powerdown mode. Hopefully > >> a future patch of yours adds that back for those platforms in the > >> pinmux world. ...same for restore. > > > > S3C64xx can be switched to power down pin configuration manually, but > > if you don't do it, it will activate it automatically after entering > > sleep mode. > > How would restore work in that case? I'd imagine that it would > automatically switch out of the powerdown config at wakeup before > running software? That doesn't seem like a great idea. This is configurable. There is a bit that determines whether it should switch back to normal config automatically or not. What's interesting is that AFAIR current code uses automatic switch, which even with the glitch prevention in resume can glitch things, due to the period of time between wake-up and resume when pins are misconfigured. I think we should just configure this bit for manual switch back and trigger the switch from .resumed() callback of the pin controller in pinctrl-s3c64xx driver. I will post a patch for this some day. > I think that to make S3C64xx work properly we'd need to solve. > > > I wouldn't be opposed to a re-spin to address some of the above, but I > also won't object to this landing and remaining issues being addressed > in future patches. This patch definitely does make things better and > no worse. :) Let's see. If nobody takes this until Monday, which is very likely, I will send new version. > On exynos5250-snow (pinmux backported to 3.8): > > Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> Thanks. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |