Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: > This patch adds master driver for PWM/timer block available on many > Samsung SoCs providing clocksource and PWM output capabilities. > > Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > .../devicetree/bindings/pwm/pwm-samsung.txt | 37 ++ > drivers/clocksource/Kconfig | 1 + > drivers/mfd/Kconfig | 3 + > drivers/mfd/Makefile | 1 + > drivers/mfd/samsung-pwm.c | 439 +++++++++++++++++++++ > drivers/pwm/Kconfig | 1 + > include/linux/mfd/samsung-pwm.h | 49 +++ > include/linux/platform_data/samsung-pwm.h | 28 ++ > 8 files changed, 559 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-samsung.txt > create mode 100644 drivers/mfd/samsung-pwm.c > create mode 100644 include/linux/mfd/samsung-pwm.h > create mode 100644 include/linux/platform_data/samsung-pwm.h Why is that an MFD driver, and why aren't you using the PWM APIs for it ? Also, you probably want to look at using the regmap APIs for your IO. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html