Hi Arnd, thanks again for taking the time to look at the changes. Am Montag, 25. März 2013, 23:00:46 schrieb Arnd Bergmann: > On Monday 25 March 2013, Heiko Stübner wrote: > > Add the necessary code to initialize the interrupt controller > > thru devicetree data using the irqchip infrastructure. > > > > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > > The binding looks fine now. I have a few detail comments but am happy > with the series otherwise. > > > +Required properties: > > +- compatible: Compatible property value should be "samsung,s3c24xx-irq" > > + for non s3c2416 machines and "samsung,s3c2416-irq" for s3c2416 > > machines > > We try to avoid wildcards in the "compatible" properties. Better use > the name of the first SoC that had this controller, and let the other > ones mark themselves as compatible with that one. > > I guess "samsung,s3c2410-irq" would be the right identifier here. ok, sounds sensible > > +- #interrupt-cells : Specifies the number of cells needed to encode an > > + interrupt source. The value shall be 4 and interrupt descriptor shall > > + have the following format: > > + <ctrl_num ctrl_irq parent_irq type> > > + > > + ctrl_num contains the controller to use: > > + - 0 ... main controller > > + - 1 ... sub controller > > + - 2 ... second main controller on s3c2416 and s3c2450 > > + ctrl_irq contains the interrupt bit of the controller > > + parent_irq contains the parent bit in the main controller and will be > > + ignored in main controllers > > I expected the second and third cell to be in the opposite order, so > the meaning of the second cell is always the same. ok, so we do <ctrl_num parent_irq ctrl_irq type>, right? ... As it only involves exchanging the intspec values, that's easy :-) > > + /* we're using individual domains for the non-dt case > > + * and one big domain for the dt case where the subintc > > + * starts at hwirq number 32. > > + */ > > + offset = (intc->domain->of_node) ? 32 : 0; > > Wouldn't it be easier to always use the same setup for the domains here? nope ... the non-dt domains are not uniform (different lengths and start-irqs) to recreate the static irq mappings that are still needed. For the non-dt case it also implement the handling of the external interrupts that is not part of the interrupt-controller itself but comes from the gpio-registers and will move to pinctrl for dt machines. My hope is still to move to dt in a "reasonable" time, so this stuff can go away then altogether. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |