On 03/25/2013 12:10 PM, Thomas Abraham wrote: >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/video/samsung-fimd.txt >> @@ -0,0 +1,68 @@ >> +Device-Tree bindings for Samsung SoC display controller (FIMD) [...] >> +- interrupts : should contain a list of all FIMD IP block interrupts: >> + FIFO Level, VSYNC, LCD_SYSTEM. The interrupt specifier format depends >> + on the interrupt controller used. Since the interrupt order is supposed to be defined by the binding, perhaps it could be rephrased to something like: - interrupts : should contain a list of all FIMD IP block interrupts in order: FIFO Level, VSYNC, LCD_SYSTEM. The interrupt specifier format depends on the interrupt controller used. >> +- interrupt-names : should contain the interrupt names: "fifo", "vsync", >> + "lcd_sys", in the same order as they were listed in the interrupts >> + property. >> + >> +- pinctrl : property defining the pinctrl configurations with a phandle >> + >> +- pinctrl-names : "default" state needs to be specified in the fimd node >> + The pinctrl bindings defined in >> + ../../../pinctrl/pinctrl-bindings.txt must be used to define a >> + pinctrl state named "default". The path should be ../pinctrl/pinctrl-bindings.txt. It probably makes to sense to either have this one sentence or pinctrl/pinctrl-names properties listed with their description. So for example - pinctrl : pin control group to be used for this controller; - pinctrl-names : should contain "default" entry; or The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used to define a pinctrl state named "default". -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |