Hello, On Mon, Mar 18, 2013 at 03:48:24PM +0530, Thomas Abraham wrote: > On 18 March 2013 14:12, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > > On Sat, Mar 16, 2013 at 06:20:01PM +0530, Thomas Abraham wrote: > >> The mxs platform specific clk-div clock is an extended version of the > >> basic integer divider clock type that supports checking the stability > >> status of the divider clock output. This type of clock is found on > >> some of the Samsung platforms as well. So let the mxs specfic clk-div > >> clock type be a generic clock type that all platforms can utilize. > >> > >> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > >> Cc: Mike Turquette <mturquette@xxxxxxxxxx> > >> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > >> --- > >> drivers/clk/Makefile | 1 + > >> drivers/clk/clk-divider-status.c | 119 ++++++++++++++++++++++++++++++++++++++ > >> drivers/clk/mxs/Makefile | 2 +- > >> drivers/clk/mxs/clk-div.c | 110 ----------------------------------- > >> drivers/clk/mxs/clk.h | 12 +++- > >> include/linux/clk-provider.h | 21 +++++++ > >> 6 files changed, 151 insertions(+), 114 deletions(-) > >> create mode 100644 drivers/clk/clk-divider-status.c > >> delete mode 100644 drivers/clk/mxs/clk-div.c > > > > From my quick testing, it seems working for mxs platform. But it's hard > > to review the changes. Making it two steps might be helpful for > > reviewer: > > > > 1) git mv drivers/clk/mxs/clk-div.c drivers/clk/clk-divider-status.c > > 2) make changes on drivers/clk/clk-divider-status.c > > Thanks Shawn for your comments. I will split this patch as you > suggested and post again. I didn't try to look at your patch, but maybe format-patch -M is enough to make the patch easier to parse (for humans). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |