Hi Sylwester,
On Thu, Mar 7, 2013 at 9:05 PM, Sylwester Nawrocki
<s.nawrocki@xxxxxxxxxxx> wrote:
> On 03/07/2013 06:31 AM, Shaik Ameer Basha wrote:
>> s3c_set_clksrc() updates the clock source as per u-boot settings.
>> This patch adds the functionality to overwrite u-boot settings,
>> if user provides the clock parent field. In case of wrong source
>> provided by the user, it will retain the u-boot settings.
>>
>> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx>
>> ---
>> arch/arm/plat-samsung/clock-clksrc.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/plat-samsung/clock-clksrc.c b/arch/arm/plat-samsung/clock-clksrc.c
>> index 786a410..4fecd80 100644
>> --- a/arch/arm/plat-samsung/clock-clksrc.c
>> +++ b/arch/arm/plat-samsung/clock-clksrc.c
>> @@ -150,7 +150,12 @@ void __init_or_cpufreq s3c_set_clksrc(struct clksrc_clk *clk, bool announce)
>> return;
>> }
>>
>> - clk->clk.parent = srcs->sources[clksrc];
>> + if (clk->clk.parent) {
>> + if (s3c_setparent_clksrc(&clk->clk, clk->clk.parent))
>> + clk->clk.parent = srcs->sources[clksrc];
>> + } else {
>> + clk->clk.parent = srcs->sources[clksrc];
>> + }
>
> May I ask what do you need this for ? This code won't be used for
> Exynos4 and Exynos5 SoCs starting from 3.10. And it is going to be
> removed once other platforms are converted to the new Samsung clocks
> driver.
I had some issues in exynos5 with out this implementation.
But yes... you are right, once we move to common clock framework (CCF)
we don't require this change, as CCF doesn't use this (for exynos 4/5).
What about all old non-dt based platforms?
Cant they use this change until they move to DT and CCF?
Regards,
Shaik Ameer Basha
>
> Regards,
> Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
