On 03/13/2013 07:01 PM, Doug Anderson wrote: > Naveen, > > On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi > <ch.naveen@xxxxxxxxxxx> wrote: >> Doug, There was a comment from Lars regarding the match not >> being NULL, if driver depends on CONFIG_OF. So, i've removed >> the NULL check in v2 of this patch. >> https://patchwork.kernel.org/patch/2222841/ >> >> I'm checking the return value of get_version() for -ve values before >> assigning to info->version. So, i left the (unsigned int) unchanged. > > Hmmm, I guess this was the point that confused me. I went back and > agree with Lars--it can't be NULL. ...but that means that > exynos_adc_get_version() can't return an error, so why are we checking > for an error? Agreed. Adding the dependency on OF in Kconfig should be all that is needed. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |