Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham:
> On 12 March 2013 05:14, Heiko Stübner <heiko@xxxxxxxxx> wrote:
> > This let to the suspend init never being reached on non-DT platforms.
> >
> > Signed-off-by: Heiko Stueber <heiko@xxxxxxxxx>
> > ---
> >
> > drivers/clk/samsung/clk.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> > index d36cdd5..1a5de69 100644
> > --- a/drivers/clk/samsung/clk.c
> > +++ b/drivers/clk/samsung/clk.c
> > @@ -57,8 +57,6 @@ void __init samsung_clk_init(struct device_node *np,
> > void __iomem *base,
> >
> > unsigned long nr_rdump)
> >
> > {
> >
> > reg_base = base;
> >
> > - if (!np)
> > - return;
>
> Hi Heiko,
>
> Sorry, I did not understand the need for this. Could you please add
> few more details on this change.
Hi Thomas,
On non-dt platforms the init would stop here, therefore never reaching the
code that inits the syscore ops below to save the register values on suspend
and restores them on resume.
I might be overlooking something, but I think we want to save/restore the
register values on both dt and non-dt platforms.
Heiko
> > #ifdef CONFIG_OF
> >
> > clk_table = kzalloc(sizeof(struct clk *) * nr_clks, GFP_KERNEL);
> >
> > --
> > 1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
