Thomas,
Thank you for doing this! :)
On Wed, Mar 6, 2013 at 4:36 AM, Thomas Abraham
<thomas.abraham@xxxxxxxxxx> wrote:>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 17dd951..434e440 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -35,9 +50,8 @@
> */
> dwmmc3@12230000 {
> slot@0 {
> - gpios = <&gpc4 0 2 0 0>, <&gpc4 1 2 3 0>,
> - <&gpc4 3 2 3 0>, <&gpc4 4 2 3 0>,
> - <&gpc4 5 2 3 0>, <&gpc4 6 2 3 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
nit: Move comment about EMI to the "pinctrl@11400000" that you added
earlier in this file. ...then move the pinctrl-names and pinctrl-0 to
"cros5250.dtsi". This is not major and could be done in a follow-up
patch.
I done basic testing of this patch series on exynos5250-snow atop
linux-next 20130307. By series I mean these patchwork IDs:
2224531 New mmc: sdhci-s3c: let device core setup the default
pin configuration
2224621 New spi: s3c64xx: let device core setup the default
pin configuration
2224731 New input: samsung-keypad: let device core setup the
default pin configuration
2224801 New ASoC: samsung: let device core setup the default
pin configuration
2224851 New mmc: dwmmc: let device core setup the default pin
configuration
2225141 New [1/2] ARM: dts: add pin state information in
client nodes for Exynos4 platforms
2225151 New [2/2] ARM: dts: add pin state information in
client nodes for Exynos5 platforms
Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
This patch looks good to me with or without the above nit fix.
Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
