On 03/05/2013 11:06 AM, Sachin Kamat wrote: > On 5 March 2013 15:34, Padmavathi Venna <padma.v@xxxxxxxxxxx> wrote: >> This patch removes custom way of adding spi dma channels and >> adds according to new generic DMA DT bindings on samsung exynos4 >> and exynos5440 platforms. >> >> Signed-off-by: Padmavathi Venna <padma.v@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 15 +++++++++------ >> arch/arm/boot/dts/exynos5440.dtsi | 5 +++-- >> 2 files changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi ... >> @@ -246,8 +247,9 @@ >> compatible = "samsung,exynos4210-spi"; >> reg = <0x13930000 0x100>; >> interrupts = <0 67 0>; >> - tx-dma-channel = <&pdma1 7>; /* preliminary */ >> - rx-dma-channel = <&pdma1 6>; /* preliminary */ >> + dmas = <&pdma0 7 >> + &pdma0 6>; > > Shouldn't these be pdma1 as was earlier? Yes, it should. And this is also what the SoC documentation says - SPI1 is assigned to Peri DMA1. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html