Hi, On Sunday 03 of March 2013 12:17:29 Sylwester Nawrocki wrote: > Hi, > > On 03/03/2013 02:08 AM, Heiko Stübner wrote: > > But is there an easy way to define more than one alias? On the s3c2416 > > for example the hsmmc hclk is the "hsmmc" io-clock, as well as the > > source for the "mmc_busclk.0". Same for the "uart" pclk, that is also > > a baud clock source. > This driver currently provides for only one additional clkdev lookup > entry per a platform clock. I pointed out this desing issue in the > early version of the patch set. It's because a machine clock definition > is coupled with a clock consumer definition. And IMO various > samsung_clock_register_* functions should not have > clk_register_clkdev() inside them. I.e. first step could be registering > all machine clocks and in the second one clkdev lookup entries could be > created. This is how most (all?) existing SoC clock drivers are > working. > > But those multiple aliases are important only for machines with device > tree support, aren't they ? I suppose you meant _without_ device tree support, right? > I hope this patch series gets merged early to linux-next in the 3.10 > cycle so the multiple accumulated fixup patches for this clock driver > can be merged as well and issues like that you pointed out can be > resolved with incremental patches. Yes, I hope so too. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |