Hi Vikas, On 27 February 2013 14:13, Vikas Sajjan <vikas.sajjan@xxxxxxxxxx> wrote: > Adds FIMD DT binding documentation both SoC and Board, with an example > > Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx> > --- > .../devicetree/bindings/video/exynos-fimd.txt | 46 ++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/exynos-fimd.txt > > diff --git a/Documentation/devicetree/bindings/video/exynos-fimd.txt b/Documentation/devicetree/bindings/video/exynos-fimd.txt > new file mode 100644 > index 0000000..b3542b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/exynos-fimd.txt > @@ -0,0 +1,46 @@ > +Device-Tree bindings for Exynos SoC display controller (FIMD) > + > +FIMD stands for Fully Interactive Mobile Display, is the Display Controller for > +the Exynos series of SoCs which transfers the image data from a video buffer I think this should be Samsung series of SoCs intead of Exynos series. As such the file name could be samsung-fimd.txt. > +located in the system memory to an external LCD interface. > + > +Required properties: > +- compatible := value can be one these below "value should be one of the following:" > + "samsung,s3c2443-fimd"; /* for S3C24XX SoCs */ > + "samsung,s3c6400-fimd"; /* for S3C64XX SoCs */ > + "samsung,s5p6440-fimd"; /* for S5P64X0 SoCs */ > + "samsung,s5pc100-fimd"; /* for S5PC100 SoC */ > + "samsung,s5pv210-fimd"; /* for S5PV210 SoC */ > + "samsung,exynos4210-fimd"; /* for Exynos4 SoCs */ > + "samsung,exynos5250-fimd"; /* for Exynos5 SoCs */ blank line here would make it more readable? > +- reg := physical base address of the fimd and length of memory mapped region > +- interrupt-parent := reference to the interrupt combiner node with phandle > +- interrupts := interrupt number from the combiner to the cpu > + we have 3 interrupts and the Interrupt combiner order is > + FIFO Level, VSYNC and LCD_SYSTEM. Make sure to mention order > + as VSYNC, FIFO Level and LCD_SYSTEM as show in the example below. Please rephrase the above as there seems to be difference in order in the above 2 lines itself. :) -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |