Hi Leela, On Wed, Feb 27, 2013 at 2:56 PM, Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> wrote: > Hello Vikas, > > On Wed, Feb 27, 2013 at 2:15 PM, Vikas Sajjan <sajjan.linux@xxxxxxxxx> wrote: >> >> Hi Leela, >> >> On Tue, Feb 26, 2013 at 4:55 PM, Leela Krishna Amudala >> <l.krishna@xxxxxxxxxxx> wrote: >> > This adds common FIMD device node for all Exynos5 SoCs. >> > >> > Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> >> > --- >> > arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> > b/arch/arm/boot/dts/exynos5250.dtsi >> > index 3acf594..0ee4706 100644 >> > --- a/arch/arm/boot/dts/exynos5250.dtsi >> > +++ b/arch/arm/boot/dts/exynos5250.dtsi >> > @@ -583,4 +583,11 @@ >> > reg = <0x14450000 0x10000>; >> > interrupts = <0 94 0>; >> > }; >> > + >> > + fimd { >> > + compatible = "samsung,exynos5-fimd"; >> I think we can modify this as "samsung,exynos5250-fimd", please refer >> to the discussion at https://patchwork.kernel.org/patch/2144861/ > > Then in that case this compatible string has to be modify in driver also. yea, right. Will be posting the changes soon. > > Best wishes, > Leela Krishna Amudala. > >> > + interrupt-parent = <&combiner>; >> > + reg = <0x14400000 0x40000>; >> > + interrupts = <18 5>, <18 4>, <18 6>; >> > + }; >> > }; >> > -- >> > 1.8.0 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe >> > linux-samsung-soc" in >> > the body of a message to majordomo@xxxxxxxxxxxxxxx >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-samsung-soc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html