On 26 February 2013 16:52, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Tue, Feb 26, 2013 at 04:46:01PM +0530, Inderpal Singh wrote: >> On 26 February 2013 15:32, Russell King - ARM Linux >> <linux@xxxxxxxxxxxxxxxx> wrote: >> > On Tue, Feb 26, 2013 at 03:26:53PM +0530, Inderpal Singh wrote: >> >> Only cortex-a9 based samsung platforms have l2x0 cache controller. Hence check >> >> the same before restoring the cache in resume. >> > >> > Why is this patch soo complicated? Can't you read the CPUs MIDR register >> > from assembly code? >> >> I wanted to read MIDR only once thats why didn't read in resume >> function in assembly as the same resume function gets used in cpuidle >> path. > > It's more expensive to load it from memory than to read it from CP15. Ok, I will change it to read from CP15 in assembly and resubmit the patch. Thanks for the review. Regards, Inder -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html