Am Mittwoch, 13. Februar 2013, 06:05:36 schrieb Kukjin Kim:
> commit 7b45ed96 ("ARM: S3C24XX: handle s3c2412 eints using new
> infrastructure") introduced build warning and this patch fixes
> that:
>
> drivers/gpio/gpio-samsung.c: In function 's3c24xx_gpiolib_fbank_to_irq':
> drivers/gpio/gpio-samsung.c:1126:5: warning: suggest explicit braces to
> avoid ambiguous 'else' [-Wparentheses]
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
right ... this way it's definitly better
Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> drivers/gpio/gpio-samsung.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index df096dc..a811d0f 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -1123,11 +1123,12 @@ int samsung_gpiolib_to_irq(struct gpio_chip *chip,
> unsigned int offset) #ifdef CONFIG_PLAT_S3C24XX
> static int s3c24xx_gpiolib_fbank_to_irq(struct gpio_chip *chip, unsigned
> offset) {
> - if (offset < 4)
> + if (offset < 4) {
> if (soc_is_s3c2412())
> return IRQ_EINT0_2412 + offset;
> else
> return IRQ_EINT0 + offset;
> + }
>
> if (offset < 8)
> return IRQ_EINT4 + offset - 4;
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
