On Wed, Feb 6, 2013 at 10:56 PM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: > On 02/07/2013 12:06 PM, Manish Badarkhe wrote: >> Hi Tushar >> >> On Thu, Feb 7, 2013 at 11:56 AM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: >>> On 02/07/2013 11:47 AM, Kumar, Anil wrote: >>>> On Thu, Feb 07, 2013 at 10:45:25, Tushar Behera wrote: >>>>> Added GPIO buttons DT node to Arndale board file. >>>>> >>>>> Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx> >>>>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >>>>> --- >>>>> This series is based on for-next branch of Kukjin Kim's tree >>>>> and added on top of the below patch: >>>>> https://patchwork.kernel.org/patch/2042451/ >>>>> --- >>>>> arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ >>>>> 1 files changed, 48 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts >>>>> index 63572f9..9ce40df 100644 >>>>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts >>>>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts >>>>> @@ -119,4 +119,52 @@ >>>>> spi_2: spi@12d40000 { >>>>> status = "disabled"; >>>>> }; >>>>> + >>>>> + gpio_keys { >>>>> + compatible = "gpio-keys"; >>>>> + #address-cells = <1>; >>>>> + #size-cells = <0>; >>>> >>>> Just want to understand why these properties are here? >>>> As these properties are for child dt node. But have not seen >>>> anyone is using here. >>>> >>> >>> That is how gpio_keys node entries are defined in other .dts files. >> >> I have gone through example for address-cells and size-cells in following link: >> http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing >> >> which indicates that these fields are for child "reg". >> I think, here in child node there is no "reg". so there is no use >> of address-cells and size-cells propeties. >> > > Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt > > And whether these properties are required or not, I will let device tree > experts to comment on that. > > As such, currently all node entries for gpio_keys use these properties. you can just verify by a simple test. delete the 2 lines. address-cells and size cells. this will have no affect. now with these 2 lines deleted lines add a dummy reg property with address and cell. dtb compiler will warn. So I think what manish reffered is right. There is also a reference of smdk4210 for kepads. > > -- > Tushar Behera > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |